Fixed winpath to path, Modified create domain #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified $::winpath to $::path
Code for Vexasoft_Cmdlet_Library_x64 Package, it is required for RDP
Adding "provider=powershell" for execs in 'enable_rdp_connections' and 'set_rdp_supported_clients'. Also changed command accordingly
|
Issue #5 |
|
Vijay, I want to remove the dep on the Vexasoft cmdlet. I've started looking at new ways to enable RDP simply using the windows registry module. Call me to discuss |
This reverts commit 45bf6e9.
|
Reverted Code for Vexasoft pacage, as we do not want to utilize vexasoft package for rdp in our module. |
removing $domain_username parameter as only admin password is required for domain join command. Adding provide=powershell changing unless to onlyif
AD-Domain_Services windows feature is required as part of create domain process
|
Vijay, can you please do a pull to update your code then resubmit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified$::winpath to $ ::path