Merge pull request #1352 from peppy/dont-set-on-get

Stop ConfigManager from setting a default when calling GetOriginalBindable
ppy · Jan 26, 2018 · 209021f · 209021f
2 parents 332d133 + 1e46bc2
commit 209021f
Showing 1 changed file with 3 additions and 8 deletions.
diff --git a/osu.Framework/Configuration/ConfigManager.cs b/osu.Framework/Configuration/ConfigManager.cs
@@ -129,19 +129,14 @@ private Bindable<U> set<U>(T lookup, U value)
             return bindable;
         }
 
-        public U Get<U>(T lookup)
-        {
-            return GetOriginalBindable<U>(lookup).Value;
-        }
+        public U Get<U>(T lookup) => GetOriginalBindable<U>(lookup).Value;
 
         protected Bindable<U> GetOriginalBindable<U>(T lookup)
         {
-            IBindable obj;
-
-            if (ConfigStore.TryGetValue(lookup, out obj))
+            if (ConfigStore.TryGetValue(lookup, out IBindable obj))
                 return obj as Bindable<U>;
 
-            return set(lookup, default(U));
+            return null;
         }
 
         /// <summary>