Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of old score es index #11544

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Remove usage of old score es index #11544

merged 1 commit into from
Oct 11, 2024

Conversation

nanaya
Copy link
Collaborator

@nanaya nanaya commented Oct 10, 2024

Everything is using the solo scores now.

Copy link
Collaborator

@notbakaneko notbakaneko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does anything else need to be updated (like stop calling the lio)?

@peppy
Copy link
Sponsor Member

peppy commented Oct 11, 2024

Is a valid point, let me double check.

@peppy
Copy link
Sponsor Member

peppy commented Oct 11, 2024

It should be fine. That endpoint is specifically used for cleaning up ES scores after a change in user state. The return value is never used so I'll just remove all calls to it.

@peppy peppy merged commit a8faa3e into ppy:master Oct 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants