Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RO] Add Upgrading to lazer #10788

Merged
merged 13 commits into from
Jan 25, 2024
Merged

[RO] Add Upgrading to lazer #10788

merged 13 commits into from
Jan 25, 2024

Conversation

28edx
Copy link
Contributor

@28edx 28edx commented Jan 13, 2024

Reuploading this because I forgot to change branch.
Translation for the Upgrading to lazer article.

Self-check

Copy link
Contributor

@NiceAesth NiceAesth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the translation, I have went through your changes and reviewed them. Please keep this feedback in mind for future contributions.
There are a lot of changes so you will have to click on the view more button as they do not all display. You can view them in a full list here.

As a note, please review the existing term usage in the stable translation:
https://gist.githubusercontent.com/NiceAesth/eea5630fa03038fb06bc83274626dc6c/raw/4ecfb996496c016ca084d4bd5fdcc3d6cdb84c3d/ro.txt

as well as crowdin:
https://crowdin.com/translate/osu-web/all/en-ro

@entwastaken if you wish to double check, please feel free to do so.

wiki/Help_centre/Upgrading_to_lazer/ro.md Outdated Show resolved Hide resolved
wiki/Help_centre/Upgrading_to_lazer/ro.md Outdated Show resolved Hide resolved
wiki/Help_centre/Upgrading_to_lazer/ro.md Outdated Show resolved Hide resolved
wiki/Help_centre/Upgrading_to_lazer/ro.md Outdated Show resolved Hide resolved
wiki/Help_centre/Upgrading_to_lazer/ro.md Outdated Show resolved Hide resolved
wiki/Help_centre/Upgrading_to_lazer/ro.md Outdated Show resolved Hide resolved
[^map-only]: Doar beatmap-ul.
[^all-files]: Toate fișierele.
[^editor-precise-rotation]: Lipsa funcției precise de rotație.
[^incompatibilities]: Niște funcții în editor vor cauza beatmap-urile să ruleze greșit în stable - va fi rezolvat în curând.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[^incompatibilities]: Niște funcții în editor vor cauza beatmap-urile să ruleze greșit în stable - va fi rezolvat în curând.
[^incompatibilities]: Unele funcții în editor vor cauza beatmap-urile să ruleze greșit în stable - va fi rezolvat în curând.

Should probably be changed in the original version. (This is also no longer the case with the .olz and .osz format.) @Walavouchey would like your input on this

Copy link
Contributor

@TicClick TicClick Jan 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(English line:

[^incompatibilities]: Some editor features will cause beatmaps to play incorrectly in stable — will be fixed soon.
)

wiki/Help_centre/Upgrading_to_lazer/ro.md Outdated Show resolved Hide resolved
wiki/Help_centre/Upgrading_to_lazer/ro.md Outdated Show resolved Hide resolved
wiki/Help_centre/Upgrading_to_lazer/ro.md Outdated Show resolved Hide resolved
28edx and others added 2 commits January 14, 2024 02:45
Co-authored-by: Andrei Baciu <8437201+NiceAesth@users.noreply.github.com>
@28edx
Copy link
Contributor Author

28edx commented Jan 14, 2024

Wow, that's what I get for breezing trough it translating it, I deeply apologize for my unprofessionalism and for all of these grammatical errors.

I approved the suggestions.

Felt like I was back in high school hearing my teacher review someone's work. And also somehow failed to notice some english words not being separated with a „-”.

Copy link
Contributor

@NiceAesth NiceAesth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok

@TicClick TicClick merged commit f79701e into ppy:master Jan 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants