Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix small mistake in History of osu! 2007 #10840

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Tanza3D
Copy link
Contributor

@Tanza3D Tanza3D commented Jan 25, 2024

For the first change: Judging by the fact that the song select has the "Play Level", it's easy to make the assumption that this is in fact the level select itself, and not just the edit level select. This is also proven by this version on Osekai Snapshots

For the second change: For the version shown in the image just above, the same selection carousel was used inside the edit menu, once again shown in this version, and also judging by the fact that this UI was never used solely as the edit level select. This orange version was however used for a few days as the primary song select, still, so unsure about entirely removing it.

First actual PR on osu-wiki so hope I've done things right here :)

Self-check

@Tanza3D Tanza3D changed the title Improve 2007 history page Improve History of osu! 2007 Jan 25, 2024
@Tanza3D Tanza3D changed the title Improve History of osu! 2007 Fix small mistake in History of osu! 2007 Jan 25, 2024
@pull-request-size pull-request-size bot added size/M and removed size/S labels Jan 25, 2024
Copy link
Contributor

@agatemosu agatemosu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spanish and french can be changed to that

wiki/History_of_osu!/2007/es.md Show resolved Hide resolved
wiki/History_of_osu!/2007/fr.md Show resolved Hide resolved
@cl8n
Copy link
Member

cl8n commented Jan 25, 2024

the orange one should probably not be deleted here, just moved if necessary and given a more accurate description

@Tanza3D Tanza3D marked this pull request as draft February 2, 2024 19:01
Copy link
Contributor

@JuanM4T JuanM4T left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the other languages can also be swapped with those.

idk why Portuguese keeps the English but I've kept it in English for coherence's sake with the original.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pemilihan Lagu

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Выбор песни

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Song Selection

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Muziekselectie

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants