Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an action to automatically add area: labels #10924

Merged
merged 7 commits into from
Feb 16, 2024
Merged

Conversation

agatemosu
Copy link
Contributor

@agatemosu agatemosu commented Feb 9, 2024

@agatemosu agatemosu changed the title Add an action to automatically label area: tags Add an action to automatically add area: labels Feb 9, 2024
.github/labeler.yml Show resolved Hide resolved
@TicClick
Copy link
Contributor

TicClick commented Feb 9, 2024

good job regardless (action: https://github.com/actions/labeler)

@Walavouchey Walavouchey added the area:meta non-article files label Feb 10, 2024
TicClick
TicClick previously approved these changes Feb 10, 2024
@TicClick
Copy link
Contributor

think it's good to go, but I'd like a second pair of eyes in case I missed something (the docs are convoluted)

.github/workflows/labeler.yml Outdated Show resolved Hide resolved
Comment on lines +1 to +4
"area:help centre":
- changed-files:
- any-glob-to-any-file:
- wiki/Help_centre/**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesnt really matter but i think this is supposed to indent more like

Suggested change
"area:help centre":
- changed-files:
- any-glob-to-any-file:
- wiki/Help_centre/**
"area:help centre":
- changed-files:
- any-glob-to-any-file:
- wiki/Help_centre/**

(and all the others)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My formatters (Prettier and Red Hat) say that it is formatted like this, I searched and this page (of prettier) is an example of this

"area:news":
- changed-files:
- any-glob-to-any-file:
- news/**/*.md
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why does this one get .md when others dont?

also probably include the news images directory

Copy link
Contributor Author

@agatemosu agatemosu Feb 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the folder has config files of formatting, it can be deleted if not necessary

Co-authored-by: clayton <me@clayton.cc>
@cl8n cl8n enabled auto-merge February 16, 2024 16:24
@cl8n cl8n merged commit bdb73b2 into ppy:master Feb 16, 2024
2 checks passed
@agatemosu agatemosu deleted the labeler branch February 16, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:meta non-article files size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants