Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DE] Update Help centre/Store/Store archive #12228

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[DE] Update Help centre/Store/Store archive #12228

wants to merge 4 commits into from

Conversation

The-Last-Cookie
Copy link
Contributor

@The-Last-Cookie The-Last-Cookie commented Sep 27, 2024 •
edited
Loading

The title should be translated.

Related to #12147

Self-check

@The-Last-Cookie The-Last-Cookie changed the title [DE] Update title in Help centre/Store/Store archive [DE] Update Help centre/Store/Store archive Oct 3, 2024
@The-Last-Cookie
Copy link
Contributor Author

The-Last-Cookie commented Oct 3, 2024 •
edited
Loading

Waiting for the review by Yannic2112 to come back (his account is [likely temporarily] banned)

@osu-wiki-observatory osu-wiki-observatory bot mentioned this pull request Nov 3, 2024
Merged
1 task
@The-Last-Cookie
Copy link
Contributor Author

The-Last-Cookie commented Nov 10, 2024 •
edited
Loading

The context should be enough for anybody to understand what it is although we could turn osu!store into a link to https://osu.ppy.sh/store/listing

Debatable in my opinion. Users can already access the store via the menu header at the top, and this change is out of scope here anyway because every language would need to be adjusted.

Y2nn1c
Y2nn1c approved these changes Nov 10, 2024
View reviewed changes
Copy link
Contributor

@Y2nn1c Y2nn1c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. No mistakes in the writing and everything has been translated properly.
I think it's ready to be shipped in it's current state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Y2nn1c Y2nn1c Y2nn1c approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area:help centre area:translations size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@The-Last-Cookie @Y2nn1c