Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Main page #12251

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Update Main page #12251

wants to merge 11 commits into from

Conversation

Y2nn1c
Copy link
Contributor

@Y2nn1c Y2nn1c commented Oct 1, 2024

Added missing links
Deleted links
Moved links from "link-wall" to the header so that the wall of links under some headers gets reduced allowing people to have an easier time finding what they want
Shortened a lot of the writing. A wiki is supposed to be short, precise and to the point. Due to the sheer volume of text and links users could be discouraged to read through all of it. Shortening the writing makes sure that the wiki serves it's purpose:
to inform the people. Nobody wants to use a main page that reminds them of an essay.

Self-check

  • The changes are tested against the contribution checklist
  • Be happy
  • Decide whether or not to keep list of osu history stuff
  • Decide whether or not to keep list of organisations

@cl8n
Copy link
Member

cl8n commented Oct 1, 2024

the "SKIP_OUTDATED_CHECK" thing is for when you have a specific reason to bypass it (if you're not yet familiar with the details of this system, basically just don't write this)

@Y2nn1c
Copy link
Contributor Author

Y2nn1c commented Oct 1, 2024

the "SKIP_OUTDATED_CHECK" thing is for when you have a specific reason to bypass it (if you're not yet familiar with the details of this system, basically just don't write this)

oh ok, sry I thought it was meant for translations only so I used since I didn't change any words themselves.
So I just add the thing at the top of the file on all the other languages and thats it?

@Y2nn1c Y2nn1c changed the title Added missing links, overall visual improvement Added missing links, overall visual improvement on the main page Oct 1, 2024
wiki/Main_page/en.md Outdated Show resolved Hide resolved
wiki/Main_page/en.md Show resolved Hide resolved
wiki/Main_page/en.md Outdated Show resolved Hide resolved
wiki/Main_page/en.md Outdated Show resolved Hide resolved
@pull-request-size pull-request-size bot added size/M and removed size/S labels Oct 2, 2024
@Y2nn1c Y2nn1c changed the title Added missing links, overall visual improvement on the main page main page improvement Oct 2, 2024
@Y2nn1c Y2nn1c changed the title main page improvement Update Main page Oct 2, 2024
@Y2nn1c
Copy link
Contributor Author

Y2nn1c commented Nov 6, 2024

@cl8n I'm done so far, if you are fine with the english version, do I only put the tag for outdated translation to the other languages if required and am done with it?

Modding is part of the ranking process and we already have that linked so no need for that. Added a sentence about loved to justify the project loved link.
@The-Last-Cookie
Copy link
Contributor

The-Last-Cookie commented Nov 6, 2024

Regarding the whole article, we should discuss if we want to keep the old embellishments addressing the user directly in a very sprawling way or if we use a more plain succinct general description thing (or some sort of in-between).

Personally, I liked the phrase and turn your ideas into reality what you just had in one of your commits. Also, some German translations fit really well on the main page but that's just me.

@Y2nn1c
Copy link
Contributor Author

Y2nn1c commented Nov 9, 2024

Regarding the whole article, we should discuss if we want to keep the old embellishments addressing the user directly in a very sprawling way or if we use a more plain succinct general description thing (or some sort of in-between).

Personally, I liked the phrase and turn your ideas into reality what you just had in one of your commits. Also, some German translations fit really well on the main page but that's just me.

Tbh I thought it sounded nice but at the other hand that's not something to put into a proper main page. We already have an abnormal amount of text in it, since it should normally just be a few short sentences so I think it's right to make it as short and accurate as I can. Also what translations do you mean?

Shortened even more, final version from my part
@The-Last-Cookie
Copy link
Contributor

Both implementations (embellishments on the one, and succinct texts on the other) have their up and down sides.

I don't know how to put it really. I guess that it's just what I would like to see in the main page personally.

Finding a balance between including every important information in the text and still address the reader directly in some way or another to make the article less formal is not easy, but it is the goal in my opinion.

I will leave the final decision to the maintainers and get an impression of the article afterwards.

@cl8n
Copy link
Member

cl8n commented Nov 10, 2024

@cl8n I'm done so far, if you are fine with the english version, do I only put the tag for outdated translation to the other languages if required and am done with it?

unless you're doing something weird regarding translations (which you aren't, in this PR), you can copy and paste the thing CI tells you into each of the article's translations. or you can let a maintainer do that part for you when they're ready to merge, doesn't rly matter

i thought the changes to the links were good but I haven't reviewed the further rewording yet since u got ur account back

@cl8n cl8n self-requested a review November 10, 2024 12:01
@Y2nn1c
Copy link
Contributor Author

Y2nn1c commented Nov 10, 2024

@cl8n I'm done so far, if you are fine with the english version, do I only put the tag for outdated translation to the other languages if required and am done with it?

unless you're doing something weird regarding translations (which you aren't, in this PR), you can copy and paste the thing CI tells you into each of the article's translations. or you can let a maintainer do that part for you when they're ready to merge, doesn't rly matter

i thought the changes to the links were good but I haven't reviewed the further rewording yet since u got ur account back

Not planning to change anything, so no translated content here. This is the final version if there are no issues that others bring up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants