Merge pull request #27077 from peppy/log-fire-and-forget-better

Improve exception logging of unobserved exceptions via `FireAndForget`
ppy · Feb 10, 2024 · 4a516cb · 4a516cb
2 parents bd22685 + 0d7e82a
commit 4a516cb
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/osu.Game/Online/Multiplayer/MultiplayerClientExtensions.cs b/osu.Game/Online/Multiplayer/MultiplayerClientExtensions.cs
@@ -23,9 +23,12 @@ public static void FireAndForget(this Task task, Action? onSuccess = null, Actio
 
                     Debug.Assert(exception != null);
 
-                    string message = exception.GetHubExceptionMessage() ?? exception.Message;
+                    if (exception.GetHubExceptionMessage() is string message)
+                        // Hub exceptions generally contain something we can show the user directly.
+                        Logger.Log(message, level: LogLevel.Important);
+                    else
+                        Logger.Error(exception, $"Unobserved exception occurred via {nameof(FireAndForget)} call: {exception.Message}");
 
-                    Logger.Log(message, level: LogLevel.Important);
                     onError?.Invoke(exception);
                 }
                 else