Fix deserialise failing with some old skins

ppy · Aug 23, 2024 · 885d832 · 885d832
1 parent 3943fe9
commit 885d832
Showing 1 changed file with 24 additions and 0 deletions.
diff --git a/osu.Game/Skinning/Skin.cs b/osu.Game/Skinning/Skin.cs
@@ -248,9 +248,33 @@ public void UpdateDrawableTarget(SkinnableContainer targetContainer)
                 applyMigration(layout, target, i);
 
             layout.Version = SkinLayoutInfo.LATEST_VERSION;
+
+            foreach (var kvp in layout.DrawableInfo.ToArray())
+            {
+                foreach (var di in kvp.Value)
+                {
+                    if (!isValidDrawable(di))
+                        layout.DrawableInfo[kvp.Key] = kvp.Value.Where(i => i.Type != di.Type).ToArray();
+                }
+            }
+
             return layout;
         }
 
+        private bool isValidDrawable(SerialisedDrawableInfo di)
+        {
+            if (!typeof(ISerialisableDrawable).IsAssignableFrom(di.Type))
+                return false;
+
+            foreach (var child in di.Children)
+            {
+                if (!isValidDrawable(child))
+                    return false;
+            }
+
+            return true;
+        }
+
         private void applyMigration(SkinLayoutInfo layout, GlobalSkinnableContainers target, int version)
         {
             switch (version)