Skip to content

Commit

Permalink
Silence beatmap retrieval failures from results screen favourite button
Browse files Browse the repository at this point in the history
As reported (very poorly) in
#28991 (comment).

I believe this is a total edge case and is mostly visible on dev due to
some beatmaps existing on `osu.ppy.sh` and not on `dev.ppy.sh`, but I
tend to agree in general that these types of failures should not be
firing very loud error notifications; logging to network and disabling
the button with a tooltip adjustment should be enough.
  • Loading branch information
bdach committed Sep 6, 2024
1 parent 925710d commit 9f834ca
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion osu.Game/Screens/Ranking/FavouriteButton.cs
Original file line number Diff line number Diff line change
Expand Up @@ -76,12 +76,13 @@ private void getBeatmapSet()
};
beatmapSetRequest.Failure += e =>
{
Logger.Error(e, $"Failed to fetch beatmap info: {e.Message}");
Logger.Log($"Favourite button failed to fetch beatmap info: {e}", LoggingTarget.Network);
Schedule(() =>
{
loading.Hide();
Enabled.Value = false;
TooltipText = "this beatmap cannot be favourited";
});
};
api.Queue(beatmapSetRequest);
Expand Down

0 comments on commit 9f834ca

Please sign in to comment.