Fix conflicting keybind for "convert to stream" in editor #30252
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as of writing it conflicts with the "toggle fps" keybind
Joehuu
previously requested changes
Oct 12, 2024
There was a problem hiding this comment.
This now conflicts with the alternative redo shortcut.
This also only fixes the hotkey hint. You would need to apply the change here too:
osu/osu.Game.Rulesets.Osu/Edit/Blueprints/Sliders/SliderSelectionBlueprint.cs
Lines 394 to 398 in 2de1955
|
My bad! I suck at greping. Sorry about that 😅 If I haven't managed to overlook something again, |
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
|
Seems fine now, but I can't make the call on whether this is the desired shortcut. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #30169
Ctrl-Shift-Fis nowCtrl-Shift-Z.Why Z?
Ctrl-Shift-SandCtrl-Shift-Awere already in use.Ctrl-Shift-Dis used to close windows in GNOME by default. The "G" key inCtrl-Shift-Gis too far away, in my opinion. Using "Z" seemed like the best option, although not ideal.