Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alias: add a lib/clojurestorm alias #84

Merged
merged 2 commits into from
Jun 7, 2024

Conversation

emilaasa
Copy link
Contributor

@emilaasa emilaasa commented Jun 4, 2024

📓 Description

This is the newest and simplest way of using FlowStorm. It requires you to swap your official Clojure compiler by ClojureStorm only at dev time.

https://flow-storm.github.io/flow-storm-debugger/user_guide.html#_clojurestorm

Also updates the existing FlowStorm alias - both version and github org.

:octocat: Type of change

  • New alias
  • Update alias version

🪲 How Has This Been Tested?

  • locally tested (i.e. clj-kondo, cljstyle)

👀 Checklist

@practicalli-johnny
Copy link
Contributor

Looks very good, thank you.

Is the original :lib/flowstorm still useful to include?
I tend to mark aliases as DEPRECATED in a comment and move them to deps-deprecated.edn in the following relese.

@practicalli-johnny
Copy link
Contributor

If you can add a CHANGELOG.md entry then I am happy to merge. Something like

alias: add `:lib/clojurestorm` to run Flowstorm debugger with ClojureStorm compiler

@emilaasa
Copy link
Contributor Author

emilaasa commented Jun 7, 2024

Thanks John, I'll do that.
I think the original alias is still useful if you for some reason are not able or comfortable replacing the compiler, but I'm not sure.

This is the newest and simplest way of using FlowStorm.
It requires you to swap your official Clojure compiler by ClojureStorm only at dev time.
https://flow-storm.github.io/flow-storm-debugger/user_guide.html#_clojurestorm
@emilaasa
Copy link
Contributor Author

emilaasa commented Jun 7, 2024

I force pushed the changes to my branch to keep the commits clean - the changelog entry should be in the alias: add a lib.... commit now.

@practicalli-johnny practicalli-johnny merged commit bc5747d into practicalli:main Jun 7, 2024
3 of 4 checks passed
@practicalli-johnny
Copy link
Contributor

I will leave the original alias in place, it doesn't add much to the maintenance as they are defined together

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants