-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#973 PHP Web Server Action for built-in app development #988
Conversation
belisoful
commented
Aug 17, 2023
•
edited
Loading
edited
- Adds the PHP Dev-Test Web Server Action to serve the application. This has the feature of abiding by the "Quiet" flags at different levels. I haven't seen any other built-in PHP Web Server [Yii, Laravel] do the quiet thing. Minor feature.
- Removed "-" from CLI Text action, it was confusing
- TStdOutWriter. This fopens 'php://stdout' when processing a web page b/c STDOUT is not available.
- Corrected TOutputWriter to write to the output rather than stdout.
- Added README.md text for starting the PHP Web Server Action after installing the application.
- Adds the PHP Dev-Test Web Server Action to serve the application. This has the feature of abiding by the "Quiet" flags at different levels. I haven't seen any other built-in PHP Web Server [Yii, Laravel]. Minor feature. - Removed "-" from CLI Text action, it was confusing - TStdOutWriter. This fopens 'php://stdout' when processing a web page b/c STDOUT is not available. - Corrected TOutputWriter to write to the output rather than stdout. - Added README.md text for starting the PHP Web Server Action after installing the application.
…/Performance Mode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, as always awesome addition!
Can you please check the few comments i left?
I sat on this to "bake" for a few weeks to make sure everything needed was included. The quiet options were added because of this integration time. You have no idea how glad I am that you are here to check and validate the code. I appreciate these code reviews immensely. |
- Better documentation for TOutputWriter. - TStdOutWriter removes flush and sets the _stdout var. - TWebServerAction corrects Port var, setAll "null" check, and minor tweak to the CLI help text.
my hope is that this PR will help people get started with PRADO much faster. |
specify that it can be turned on only for the built in dev server with the getOnlyDevServer configuration option
I think that's it unless you find more. |