don't print status of cloning message when scanning remote repository… (

#50)

* don't print status of cloning message when scanning remote repository and outputting json or sarif

* highlight relevant finding lines; fix failed test (#46)

cmd/scan.go

@@ -72,7 +72,8 @@ Scans a Go module directory. To scan the current directory recursively, use goka
 			}
 			defer util.CleanupModule(moduleTempDir)
 
-			err = util.CloneModule(moduleTempDir, remoteModule, remoteBranch, keyFile)
+			// Clone the module, if the output format is JSON or SARIF don't print any progress to stdout
+			err = util.CloneModule(moduleTempDir, remoteModule, remoteBranch, keyFile, json || sarif)
 
 			if err != nil {
 				util.CleanupModule(moduleTempDir)

util/module.go

@@ -25,13 +25,17 @@ import (
 
 // CloneModule clones a remote git repository
 // An optional keyfile may be specified for use in ssh authentication
-func CloneModule(dir string, url string, branch string, keyFile string) error {
+// If quiet is true, don't print clone progress to stdout
+func CloneModule(dir string, url string, branch string, keyFile string, quiet bool) error {
 	var cloneOptions git.CloneOptions
 
-	log.Printf("Cloning new remote module: %s\n", url)
 	cloneOptions = git.CloneOptions{
-		URL:      url,
-		Progress: os.Stdout,
+		URL: url,
+	}
+
+	if !quiet {
+		log.Printf("Cloning new remote module: %s\n", url)
+		cloneOptions.Progress = os.Stdout
 	}
 
 	if len(branch) != 0 {