server: ignore exceptions in the Watcher loop #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrostyX
reviewed
Jul 12, 2024
resallocserver/manager.py
Outdated
| # unexpected failure, so let's try to recover :shrug:. If the | ||
| # parent dies, we get killed without any announcement, sounds | ||
| # fair. | ||
| pass |
There was a problem hiding this comment.
Can we at least log something (the exception) here?
This is a very poor hack, but we don't face exceptions too frequently
here. Let's restart if e.g. this happens:
Traceback (most recent call last):
File "/usr/lib64/python3.12/site-packages/sqlalchemy/engine/base.py", line 1910, in _execute_context
self.dialect.do_execute(
File "/usr/lib64/python3.12/site-packages/sqlalchemy/engine/default.py", line 736, in do_execute
cursor.execute(statement, parameters)
sqlite3.OperationalError: database is locked
While we ignore such exceptions now, we at least log out the exception
traceback for later analysis.
praiskup
force-pushed
the
praiskup-restart-watcher
branch
from
130e954
to
9e4631f
Compare
FrostyX
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very poor hack, but we don't face exceptions too frequently here. Let's restart if e.g. this happens:
Traceback (most recent call last):
File "/usr/lib64/python3.12/site-packages/sqlalchemy/engine/base.py", line 1910, in _execute_context
self.dialect.do_execute(
File "/usr/lib64/python3.12/site-packages/sqlalchemy/engine/default.py", line 736, in do_execute
cursor.execute(statement, parameters)
sqlite3.OperationalError: database is locked