-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Major update on security, improved UI and bug fix.
- Loading branch information
1 parent
4d8d4a3
commit 8de16a4
Showing
4 changed files
with
366 additions
and
461 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
8de16a4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know how removing the config sample that I relied on makes things more simple, as it makes things harder for me right now having to rewrite my script, but there is nothing I can do about it is there?
8de16a4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@michacassola , I have removed
sample-config.php
to make file manager simple, as it is a single file manager. still if you have config.php, it will work.https://github.com/prasathmani/tinyfilemanager/blob/master/tinyfilemanager.php#L135
8de16a4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't misunderstand me, I am thankful for this great piece of FOSS!
But you could have removed screenshot.gif instead which is very annoying and quite large with more than 2mb, it doesn't have to be on the same repo to be inserted into the README.MD.
Also the Dockerfile doesn't need to be there, could be in another repo as well.
And SECURITY.MD is another thing that doesn't have to be there...
So 3 files that would make more sense regarding decluttering right there.
8de16a4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dockerfile and SECURITY.MD are required files, but screenshot.gif can be compressed into small size or move to another repo.