Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ace Editor: Add offline assets #978

Open
wants to merge 1 commit into
base: offline
Choose a base branch
from

Conversation

smalos
Copy link

@smalos smalos commented Feb 23, 2023

Ace requires some other files (themes, extensions, syntax highlighting etc.)

It's probably better to place them in a subfolder within assets/js/

and then replace

'js-ace' => '<script src="assets/js/ace.js"></script>',

with

'js-ace' => '<script src="assets/js/ace/ace.js"></script>',

See discussion

@smalos
Copy link
Author

smalos commented Mar 20, 2023

@prasathmani
I submitted the pull request some time ago and I was wondering if you had a chance to review it yet and if there's anything that's unclear or needs clarification. If everything looks good, would it be possible to merge the pull request?

Thank you for your time and consideration.

@dumblob
Copy link

dumblob commented Mar 20, 2023

I am also interested in merging this (I need a standalone "independent" deployment).

@smalos
Copy link
Author

smalos commented May 4, 2023

It may be worthwhile to inquire whether there is any interest in developing a fully offline version, or whether the pull request should be closed due to the lack of response

@gerese1
Copy link

gerese1 commented May 5, 2023

I am interested in merging this application in an environment without internet.
Thank you

@ner00
Copy link
Contributor

ner00 commented May 5, 2023

I think it's worth it, but it might also be a good idea to bring the offline branch up to date with the master branch since there is more than a dozen commits in master that have not been pushed to the offline branch.

Edit: there is no conflict with this PR, I proposed #1037 since the offline branch is being neglected a bit.

@ner00
Copy link
Contributor

ner00 commented May 6, 2023

@smalos I would also encourage updating Ace to the latest version, and mention the version in the commit and PR title so it's easier to track down the line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants