-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenRTB v2.6-202309 #11
Changes from all commits
4e08b98
13f45b6
0c131e3
5cf6415
bea3d61
fcaa4c6
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,7 +8,7 @@ import ( | |
|
||
// 3.2.1 Object: BidRequest | ||
// | ||
// The top-level bid request object contains a globally unique bid request or auction ID. | ||
// The top-level bid request object contains an exchange unique bid request or auction ID. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe it's just me but I find the comment in line 25 below easier to understand than this one. At least upon first read. I realize this is the exact sentence found in the docs but, could we slightly reword? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'd like to match the spec, but I can propose an update to the spec. What would sound better? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. How about: "The top-level bid request object contains an exchange-assigned unique bid request ID or auction ID. |
||
// This id attribute is required as is at least one impression object (Section 3.2.4). | ||
// Other attributes in this top-level object establish rules and restrictions that apply to all impressions being offered. | ||
// | ||
|
@@ -22,7 +22,9 @@ type BidRequest struct { | |
// Type: | ||
// string; required | ||
// Description: | ||
// Unique ID of the bid request, provided by the exchange. | ||
// ID of the bid request, assigned by the exchange, and unique for the | ||
// exchange’s subsequent tracking of the responses. The exchange may use | ||
// different values for different recipients. | ||
ID string `json:"id"` | ||
|
||
// Attribute: | ||
|
@@ -182,6 +184,17 @@ type BidRequest struct { | |
// should be present. | ||
WLangB []string `json:"wlangb,omitempty"` | ||
|
||
// Attribute: | ||
// acat | ||
// Type: | ||
// string array | ||
// Description: | ||
// Allowed advertiser categories using the specified category taxonomy. | ||
// The taxonomy to be used is defined by the cattax field. If no cattax | ||
// field is supplied IAB Content Taxonomy 1.0 is assumed. Only one of | ||
// acat or bcat should be present. | ||
ACat []string `json:"acat,omitempty"` | ||
|
||
// Attribute: | ||
// bcat | ||
// Type: | ||
|
@@ -191,7 +204,7 @@ type BidRequest struct { | |
// category taxonomy. | ||
// The taxonomy to be used is defined by the cattax field. If no | ||
// cattax field is supplied IAB Content Category Taxonomy 1.0 is | ||
// assumed. | ||
// assumed. Only one of acat or bcat should be present. | ||
BCat []string `json:"bcat,omitempty"` | ||
|
||
// Attribute: | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,53 @@ | ||
package openrtb2 | ||
|
||
import ( | ||
"encoding/json" | ||
) | ||
|
||
// Object: DurFloors | ||
// | ||
// This object allows sellers to specify price floors for video and audio creatives, whose price varies based on time. | ||
// For example: 1-15 seconds at a floor of $5; 16-30 seconds at a floor of $10, > 31 seconds at a floor of $20. | ||
// There are no explicit constraints on the defined ranges, nor guarantees that they don't overlap. | ||
// In cases where multiple ranges may apply, it is up to the buyer and seller to coordinate on which floor is applicable. | ||
type DurFloors struct { | ||
|
||
// Attribute: | ||
// mindur | ||
// Type: | ||
// integer | ||
// Description: | ||
// An integer indicating the low end of a duration range. If this | ||
// value is missing, the low end is unbounded. Either mindur or maxdur | ||
// is required, but not both. | ||
MinDur int64 `json:"mindur,omitempty"` | ||
|
||
// Attribute: | ||
// maxdur | ||
// Type: | ||
// integer | ||
// Description: | ||
// An integer indicating the high end of a duration range. If this | ||
// value is missing, the high end is unbounded. Either mindur or maxdur | ||
// is required, but not both. | ||
MaxDur int64 `json:"maxdur,omitempty"` | ||
|
||
// Attribute: | ||
// bidfloor | ||
// Type: | ||
// float; default 0 | ||
// Description: | ||
// Minimum bid for a given impression opportunity, if bidding with a | ||
// creative in this duration range, expressed in CPM. For any creatives | ||
// whose durations are outside of the defined min/max, the bidfloor at | ||
// the Imp level will serve as the default floor. | ||
BidFloor float64 `json:"bidfloor,omitempty"` | ||
|
||
// Attribute: | ||
// ext | ||
// Type: | ||
// object | ||
// Definition: | ||
// Placeholder for vendor specific extensions to this object. | ||
Ext json.RawMessage `json:"ext,omitempty"` | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,6 +4,7 @@ import "encoding/json" | |
|
||
// Object: Refresh | ||
type Refresh struct { | ||
|
||
// Attribute: | ||
// refsettings | ||
// Type: | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request Add AutoRefresh and AutoRefreshSettings to Bid Request of the openrtb2.x/2.6.md repository lists
AutoRefresh
andAutoRefreshSettings
under theBidRequest
list but, this fields, along withDurFlooors
are not in the table depicted in the 3.2.1 - Object: BidRequest section. Are they getting added to the table, and eventually, as fields of theBidRequest
struct eventually? Should we add them to theBidRequest
object already?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious what pointed your attention to that specific commit? That was a commit to a develop branch. The location was moved to the Imp object before release.
No.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main branch correctly places the refresh object in the desired location.