Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve footer #406

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Improve footer #406

wants to merge 4 commits into from

Conversation

chlorenz
Copy link
Collaborator

No description provided.

@chlorenz chlorenz requested a review from MakisH May 13, 2024 09:49
@chlorenz chlorenz self-assigned this May 13, 2024
<footer>
<div class="row text-center">
<div class="background-dark">
<div class="container">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need more margin at the bottom. It currently seems to be quite tight at the bottom:

Screenshot from 2024-05-13 13-10-52

<div class="col-md-4 col-xs-4 text-left">
<ul class="list-unstyled">
<li>
<a class="no-icon" href="https://precice.discourse.group"><!-- <i class="fab fa-discourse fa-lg"></i> -->Forum on Discourse</a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason to keep the commented-out icons around?

<a class="no-icon" href="https://github.com/precice"><!-- <i class="fab fa-github fa-lg"></i> -->preCICE on GitHub</a>
</li>
<li>
<a href="#">License</a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On my list, I will open a PR asap.

<img alt="Creative Commons License" src="images/licensebutton-by-40_88x31.png" />
</a>
<!-- <br />
This work is licensed under a <a rel="license" href="https://creativecommons.org/licenses/by/4.0/">Creative Commons Attribution 4.0 International License</a>. -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could still be the alt of the img above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants