Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spack testing obsolete #220

Open
fsimonis opened this issue Sep 4, 2024 · 0 comments · May be fixed by #221
Open

Spack testing obsolete #220

fsimonis opened this issue Sep 4, 2024 · 0 comments · May be fixed by #221

Comments

@fsimonis
Copy link
Member

fsimonis commented Sep 4, 2024

The tests of the python bindings to keep spack working involves many layers as spack used to install packages by calling setup.py as follows:

$ python setup.py build
$ python setup.py install --root=...

As the python bindings are native extensions of precice using cython, this involved additional steps that needed testing.

Spack changed to directly using pip install in spack/spack#27798.
Meaning that we no longer need to test setup.py calls and the installation of the python bindings becomes significantly simpler and more robust.

I suggest to:

  • remove testing of setup.py calls which are anyhow deprecated.
  • remove testing of spack builds in the CI, including the generation of the build image and the checked-in spack package files.
  • remove the explicit checks for a pip environment in the setup.py.

This allows us to more aggressively push #208 and #217.

@precice precice deleted a comment Sep 4, 2024
@fsimonis fsimonis linked a pull request Sep 4, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant