-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restrict to numpy < 2 and setuptools < 72 for better compatibiltiy with CI pipeline #213
Restrict to numpy < 2 and setuptools < 72 for better compatibiltiy with CI pipeline #213
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable 👍
Will merge this now. One review should be sufficient. |
@BenjaminRodenberg I do understand these restrictions for the v2.5.1 release to keep it simple, but not for develop. numpy 2 works fine after #204. The bindings now actively prevent downstream projects (adapters and cases) from updating to numpy 2. This is a problem. The setuptools restriction only affects testing. The rest works fine. |
Thanks for the info. I was not completely aware of this connection. We then basically need the restrictions as introduced here only for pyprecice 2.x; maybe for some pyprecice 3.x releases prior to #204. For all pyprecice 3.x releases after #204 we should loosen the restriction on numpy for the reasons you already mentioned above. I'll open an issue for this that we don't forget. With spack it's unfortunately always a bit tricky to get things working properly since I'm not that deep into spack and properly testing different configurations takes some time. |
I would suggest to restrict the numpy version to
numpy<2
since the newest numpy is not well supported by our CI pipeline (see #212).