Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test spack build using external dependencies #93

Draft
wants to merge 94 commits into
base: develop
Choose a base branch
from

Conversation

BenjaminRodenberg
Copy link
Member

@BenjaminRodenberg BenjaminRodenberg commented Mar 10, 2021

Related to #86

Todo

@BenjaminRodenberg
Copy link
Member Author

I tried building the spack base image, but ran into trouble with building boost, when building locally via docker build -t external-deps -f spack/ci-spack-pyprecice-external-deps-2004.dockerfile .:

==> Installing boost-1.77.0-ih2n3iejl2kufyybakahhq4tottejwer
==> No binary for boost-1.77.0-ih2n3iejl2kufyybakahhq4tottejwer found: installing from source
==> Fetching https://boostorg.jfrog.io/artifactory/main/release/1.77.0/source/boost_1_77_0.tar.bz2
==> Ran patch() for boost
==> boost: Executing phase: 'install'
==> Error: ProcessError: Command exited with status 1:
    './bootstrap.sh' '--prefix=/spack/opt/spack/linux-ubuntu20.04-x86_64/gcc-8.4.0/boost-1.77.0-ih2n3iejl2kufyybakahhq4tottejwer' '--with-toolset=gcc' '--with-libraries=regex,wave,test,thread,exception,system,date_time,graph,locale,chrono,log,serialization,filesystem,iostreams,random,timer,atomic,program_options,math' '--without-icu'
See build log for details:
  /tmp/root/spack-stage/spack-stage-boost-1.77.0-ih2n3iejl2kufyybakahhq4tottejwer/spack-build-out.txt

This needs some further investigation.

Copy link
Member Author

@BenjaminRodenberg BenjaminRodenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, the spack package is not widely used. Testing how the package behaves with dependencies from the base system is probably useful but also increases cost for testing and general complexity. We can keep this PR lying around or close it. Any opinion @fsimonis ?

I took care of updating the most obvious parts and added some comments at the relevant places.

spack/ci-spack-pyprecice-external-deps-2004.dockerfile Outdated Show resolved Hide resolved
ADD ./spack/repo /py-pyprecice-repo

RUN source /spack/share/spack/setup-env.sh && \
spack --color=always external find --not-buildable && \
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the relevant line in this dockerfile compared to ci-spack-pyprecice-deps-2404.dockerfile

.github/workflows/build-spack.yml Outdated Show resolved Hide resolved
.github/workflows/build-env.yml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant