Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial partitioned-backwards-facing-step diverges when substeps > 0 #373

Closed
MakisH opened this issue Sep 19, 2023 · 3 comments
Closed
Labels

Comments

@MakisH
Copy link
Member

MakisH commented Sep 19, 2023

  • Tutorials state (last commit / release): 0cd624e
  • Operating system (e.g. Linux distribution and version): Ubuntu 22.04
  • preCICE Version: develop f42e6c5c
  • OpenFOAM adapter branch fix-writing, commit 7f316de6
  • OpenFOAM v2306

As discussed in precice/openfoam-adapter#305 (comment) and later, the partitioned backwards facing step tutorial diverges with the default value of substeps.

See the precice-config.xml.

As @davidscn observed, setting <exchange ... substeps="0" /> everywhere seems to give the right results.

In my view, this suggests that either:

  • preCICE gives the wrong results with the default value (@BenjaminRodenberg any clue?)
  • The OpenFOAM adapter does something wrong

Related to precice/openfoam-adapter#305 and precice/openfoam-adapter#303

@BenjaminRodenberg
Copy link
Member

Note that quasi-Newton schemes currently do not support subcycling. A corresponding error is on the way (precice/precice#1721). If the case is somehow doable with constant underrelaxation, you can use subcycling. This would be an important piece of information.

@uekerman
Copy link
Member

We also changed the default to substeps="false" now.
precice/precice#1732

@MakisH
Copy link
Member Author

MakisH commented Oct 14, 2023

This tutorial now works with preCICE and tutorials from develop.
If I set substeps=true, I do get a helpful error message in the second participant.

@MakisH MakisH closed this as completed Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

3 participants