Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make beta in partitioned heat conduction tutorial consistent with paper #378

Closed
BenjaminRodenberg opened this issue Oct 4, 2023 · 3 comments · Fixed by #379
Closed

Make beta in partitioned heat conduction tutorial consistent with paper #378

BenjaminRodenberg opened this issue Oct 4, 2023 · 3 comments · Fixed by #379
Assignees
Labels

Comments

@BenjaminRodenberg
Copy link
Member

For some reason our tutorial here uses beta = 1.3:

beta = 1.3 # parameter beta

However, the FEniCS tutorial book, p.41 and the quasi-Newton paper uses beta = 1.2. To make things consistent, we should change the value here.

@BenjaminRodenberg BenjaminRodenberg self-assigned this Oct 4, 2023
@BenjaminRodenberg
Copy link
Member Author

Also important: This change is also required for the nutils and OpenFOAM versions of this case.

@BenjaminRodenberg
Copy link
Member Author

Closed this issue via #379.

@BenjaminRodenberg
Copy link
Member Author

Marking this issue as a bug. I want to backport this fix and release it as a bugfix release via #558. Main motivation: consistency in results and literature when comparing the distributions for preCICE v2 and v3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant