Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nutils tutorials always download pyprecice 3.0.0.0 #530

Closed
MakisH opened this issue Apr 24, 2024 · 3 comments
Closed

Nutils tutorials always download pyprecice 3.0.0.0 #530

MakisH opened this issue Apr 24, 2024 · 3 comments
Assignees
@NiklasVin

Comments

@MakisH
Copy link
Member

MakisH commented Apr 24, 2024

We currently set pyprecice==3.
We should probably set pyprecice>=3,<4 or similar.
@fsimonis
Copy link
Member

We can ask for a compatible version pyprecice~=3.0

@BenjaminRodenberg
Copy link
Member

What's holding us back? I just reviewed #541 and was also a bit surprised about the pyprecice==3. In #541 we will keep it consistent with the rest and merge now.

@MakisH
Copy link
Member Author

MakisH commented Aug 19, 2024

What's holding us back?

Nothing, just priorities and time.
I think the solution with pyprecice~=3.0 is good, provided it will install a newer feature release, if available.

Happy to review PRs. 🤗

@NiklasVin NiklasVin mentioned this issue Aug 19, 2024
Merged
@MakisH MakisH closed this as completed Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NiklasVin NiklasVin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@MakisH @BenjaminRodenberg @fsimonis @NiklasVin