Use beta consistent with literature #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IshaanDesai
approved these changes
Oct 4, 2023
davidscn
reviewed
Oct 5, 2023
There was a problem hiding this comment.
Hm, the proposed changes here contradict what we do in the OpenFOAM adapter paper. There, we use 1.3 and even refer to the tutorials
We select α = 3 and β = 1.3, as used in the preCICE tutorials with other solvers
We selected these parameters due to their value in the tutorial. @MakisH opinions?
|
I remember discussing this a while ago. I think it was wrong, but kept it to stick with the tutorials. In the OpenFOAM-preCICE paper, we refer to a specific version of the tutorials, so I think we should not be restricted by that. Consistency is more important. |
MakisH
approved these changes
Oct 6, 2023
BenjaminRodenberg
added a commit
that referenced
this pull request
Jan 25, 2024
BenjaminRodenberg
added a commit
to BenjaminRodenberg/tutorials
that referenced
this pull request
Jan 25, 2024
BenjaminRodenberg
added a commit
to BenjaminRodenberg/tutorials
that referenced
this pull request
Aug 27, 2024
BenjaminRodenberg
added a commit
to BenjaminRodenberg/tutorials
that referenced
this pull request
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #378
Comments for the review: Am I missing some tutorial?