volume-coupled-flow: add y and z components in source term #544
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #542.
At the moment, the source term only considers the x-component of the read velocity in the volume coupling, even though we do exchange 2D velocities. Even though this example is completely artifical, reading only the
x
component seems to be unmotivated, and it already triggered a related question by @fsimonis when using this tutorial as a starting point.Even though we exchange 2D data in preCICE, this is copying between OpenFOAM objects, which are both 3D structures.
@tirgendetwas do I miss something here, or was this simply something that slipped the review?
Results currently:
Results with the change:
Checklist:
changelog-entries/<PRnumber>.md
.