Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

volume-coupled-flow: add y and z components in source term #544

Merged
merged 4 commits into from
Jun 27, 2024

Conversation

MakisH
Copy link
Member

@MakisH MakisH commented Jun 26, 2024

Closes #542.

At the moment, the source term only considers the x-component of the read velocity in the volume coupling, even though we do exchange 2D velocities. Even though this example is completely artifical, reading only the x component seems to be unmotivated, and it already triggered a related question by @fsimonis when using this tutorial as a starting point.

Even though we exchange 2D data in preCICE, this is copying between OpenFOAM objects, which are both 3D structures.

@tirgendetwas do I miss something here, or was this simply something that slipped the review?

Results currently:

Screenshot from 2024-06-26 16-26-28

Results with the change:

Screenshot from 2024-06-26 16-25-22

Checklist:

  • I added a summary of any user-facing changes (compared to the last release) in the changelog-entries/<PRnumber>.md.
  • I will remember to squash-and-merge, providing a useful summary of the changes of this PR.

@MakisH MakisH added the bug label Jun 26, 2024
@MakisH MakisH requested a review from fsimonis June 26, 2024 14:35
@MakisH MakisH self-assigned this Jun 26, 2024
@MakisH MakisH requested a review from davidscn June 27, 2024 09:06
@MakisH
Copy link
Member Author

MakisH commented Jun 27, 2024

Ready to review (maybe @davidscn?).
This tutorial remains a very arbitrary/constructed or even plain wrong example just to demonstrate the concept (we knew that since the design phase), but I think that this PR still fixes a bug.

@davidscn
Copy link
Member

I think the changes here require rather a conceptual review than a technical one and I am not familiar with the tutorial, what it is supposed to showcase or what the coupling is supposed to comprise. So, let me remove my review..

@davidscn davidscn removed their request for review June 27, 2024 09:44
@MakisH MakisH requested a review from uekerman June 27, 2024 10:33
Copy link
Member

@uekerman uekerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change makes sense to me, the tutorial not completely 😁

@MakisH MakisH merged commit 32b2671 into precice:develop Jun 27, 2024
1 check passed
@MakisH MakisH deleted the fix-542 branch June 27, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

volume-coupled-flow: Source term incomplete
3 participants