Add channel-transport transport OpenFOAM #551

fsimonis · 2024-07-11T11:20:52Z

This PR adds an OpenFOAM variant of the transport participant of the channel-transport tutorial.

The case uses a modified version of the scalarTransportFoam application. Main difference is that we assume U to change every timestep. Therefore we need to recompute $\phi$ every timestep.

Note that this solver conserves the overall T, leading to an accumulation of the concentration close to the outlet.

@MakisH Can you give this PR a thorough review to make it as easy to use as possible?

Result:

coarse-blob.mp4

Checklist:

I added a summary of any user-facing changes (compared to the last release) in the changelog-entries/<PRnumber>.md.
I will remember to squash-and-merge, providing a useful summary of the changes of this PR.

MakisH

Besides the fact that solver and config are in the same directory, it looks good overall. I have not yet tried to run it.

MakisH · 2024-08-29T17:02:31Z

channel-transport/README.md

@@ -41,6 +41,8 @@ Transport participant:

 * Nutils. For more information, have a look at the [Nutils adapter documentation](https://precice.org/adapter-nutils.html). This Nutils solver requires at least Nutils v7.0.

+* OpenFOAM. This case uses a modified version of scalarTransportFoam, which recomputes `phi` after the preCICE adapter reads the velocity field. Build it with `wmake`. Read more details in the [OpenFOAM adapter](https://precice.org/adapter-openfoam-overview.html). Note that T accumulates in front of the outlet as this case conserves overall T.


Suggested change

* OpenFOAM. This case uses a modified version of scalarTransportFoam, which recomputes `phi` after the preCICE adapter reads the velocity field. Build it with `wmake`. Read more details in the [OpenFOAM adapter](https://precice.org/adapter-openfoam-overview.html). Note that T accumulates in front of the outlet as this case conserves overall T.

* OpenFOAM. This case uses a modified version of scalarTransportFoam, which recomputes `phi` after the preCICE adapter reads the velocity field. Build it with `wmake`. Read more details in the [OpenFOAM adapter](https://precice.org/adapter-openfoam-overview.html). Note that `T` accumulates in front of the outlet as this case conserves overall `T`.

For consistency.

However: is this really intended, or a modelling issue?

It's a modelling issue that I couldn't find a solution for. I also ran out of people to ask for help

We should better understand this, and either add details, or fix it. I think right now it just looks wrong.

MakisH · 2024-08-29T17:11:47Z

channel-transport/transport-openfoam/.clang-format

I start feeling very uneasy that we duplicate this file everywhere.
Opened an issue: #559

There is no uniform style in the tutorials repo. I don't see an easy solution for this.

There is a .clang-format file in the root directory: https://github.com/precice/tutorials/blob/develop/.clang-format

Let's discuss in #559.

MakisH · 2024-08-29T17:13:30Z

channel-transport/transport-openfoam/.gitignore

We should have these in the central gitignore: https://github.com/precice/tutorials/blob/develop/.gitignore

The 0/ is already covered, the rest could go there as-is (strange we don't have them already).

It's the other way around.

0/ is tracked and 0.*/ ignored by default. In my case I generate 0/ from 0.orig/, which is the exact opposite of what the gitignore defines.

tutorials/.gitignore

Lines 41 to 43 in 3f253cc

0.*/

[1-9]*/

!0/

Interestingly, we don't have a .gitignore in https://github.com/precice/tutorials/tree/develop/partitioned-pipe-two-phase, which should have the same issue.

But again, the Make/-related rules can go into the central .gitignore, or at least moved to the solver directory.

channel-transport/transport-openfoam/Make/files

MakisH · 2024-08-29T17:20:43Z

channel-transport/transport-openfoam/dynamicScalarTransportFoam.C

Can you explain the exact history of this file?
What did you get from where, what did you add yourself?

Where would you expect to find this information? In the file itself or in a README in the directory of the solver?

Just here first, to decide on what to do with this header.
But eventually in the file itself.

MakisH · 2024-08-29T17:25:24Z

channel-transport/transport-openfoam/system/setExprFieldsDict

A comment here would be nice.
I assume you are initializing a blob of T at (1,1).

MakisH · 2024-08-29T17:28:59Z

channel-transport/transport-openfoam/system/fvSchemes

+/*--------------------------------*- C++ -*----------------------------------*\
+| =========                 |                                                 |
+| \\      /  F ield         | OpenFOAM: The Open Source CFD Toolbox           |
+|  \\    /   O peration     | Version:  v2312                                 |
+|   \\  /    A nd           | Website:  www.openfoam.com                      |
+|    \\/     M anipulation  |                                                 |
+\*---------------------------------------------------------------------------*/


These headers are actually misleading, since we anyway have changed these configuration files a lot compared to what you might have started from.

(referring to this file and the fvSolution)

How do you suggest me to handle this? (also in the solver source)

I am suggesting to remove the copyright header from the fvSchemes and fvSolution, because it is wrong.

What about the actual solver sources?

There we need it, since it is actually a small extension of OpenFOAM code.
But this is discussed in #551 (comment)

MakisH · 2024-08-29T17:31:00Z

channel-transport/transport-openfoam/system/fvSchemes

+divSchemes
+{
+    default         none;
+    div(phi,T)      Gauss linearUpwind grad(T);


Does tuning this maybe help with the strange values at the outlet?

Feel free to try. I wasn't able to change the behaviour.

We can eventually try this together, but I don't have the time to debug this at the moment. That's why I am giving a hint on what I think could help first.

fsimonis added 17 commits June 24, 2024 16:10

It kind of runs

1d949e5

remove blob

ea64e38

Maybe right?

a1c142c

setup setFields

f2fb4f3

Set a cylinder, increase mesh cells, add U_vol workaround

9a1e7b9

Add modified solver

e363145

Remove U_vol and rename solver

e103c9a

fix

38f1424

Revert to default schemes

14db9a1

Fix dimensions of T

a4d0899

Revert to tutorial files

900eef5

Recompute phi after the preCICE adapter

759e9e5

Correctly set blob

78e4769

Add OpenFOAM transport to README

3b001ee

Only set initial condition

c711cce

Add note about openfoam conserving T

5602cfd

Fix application name

9d72498

fsimonis requested a review from MakisH July 11, 2024 11:20

fsimonis self-assigned this Jul 11, 2024

Add changelog

7e6502b

MakisH mentioned this pull request Aug 29, 2024

Duplicate .clang-format file in OpenFOAM cases #559

Open

MakisH reviewed Aug 29, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add channel-transport transport OpenFOAM #551

Add channel-transport transport OpenFOAM #551

fsimonis commented Jul 11, 2024 •

edited

Loading

MakisH left a comment

MakisH Aug 29, 2024

fsimonis Sep 2, 2024

MakisH Sep 2, 2024

MakisH Aug 29, 2024

fsimonis Sep 2, 2024

MakisH Sep 2, 2024

MakisH Aug 29, 2024

fsimonis Sep 2, 2024

MakisH Sep 2, 2024

MakisH Aug 29, 2024

fsimonis Sep 2, 2024 •

edited

Loading

MakisH Sep 2, 2024

MakisH Aug 29, 2024

MakisH Aug 29, 2024

fsimonis Sep 2, 2024 •

edited

Loading

MakisH Sep 2, 2024

fsimonis Sep 4, 2024

MakisH Sep 4, 2024

MakisH Aug 29, 2024

fsimonis Sep 2, 2024

MakisH Sep 2, 2024

		@@ -41,6 +41,8 @@ Transport participant:

		* Nutils. For more information, have a look at the [Nutils adapter documentation](https://precice.org/adapter-nutils.html). This Nutils solver requires at least Nutils v7.0.

		* OpenFOAM. This case uses a modified version of scalarTransportFoam, which recomputes `phi` after the preCICE adapter reads the velocity field. Build it with `wmake`. Read more details in the [OpenFOAM adapter](https://precice.org/adapter-openfoam-overview.html). Note that T accumulates in front of the outlet as this case conserves overall T.

Add channel-transport transport OpenFOAM #551

Are you sure you want to change the base?

Add channel-transport transport OpenFOAM #551

Conversation

fsimonis commented Jul 11, 2024 • edited Loading

MakisH left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fsimonis Sep 2, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fsimonis Sep 2, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fsimonis commented Jul 11, 2024 •

edited

Loading

fsimonis Sep 2, 2024 •

edited

Loading

fsimonis Sep 2, 2024 •

edited

Loading