Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in components.yaml #553

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Fix typo in components.yaml #553

merged 1 commit into from
Jul 16, 2024

Conversation

uekerman
Copy link
Member

There are likely more place where this needs to be updated:

@uekerman uekerman requested a review from MakisH July 16, 2024 08:44
@MakisH
Copy link
Member

MakisH commented Jul 16, 2024

That's a known one, we were mainly avoiding touching it because it touched many other files already (pretty much every workflow specifying a CalculiX version). But good time to fix it, before we add more workflows.

Should not need to update many files after addressing #552.

Copy link
Member

@MakisH MakisH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this and observe what fails (and fix that as well).

@MakisH MakisH merged commit c0f708a into develop Jul 16, 2024
1 check passed
@MakisH MakisH deleted the uekerman-patch-2 branch July 16, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants