From 8109756e5b79bbec3f4a82c577c54d3eb6cb5631 Mon Sep 17 00:00:00 2001 From: Benjamin Rodenberg Date: Mon, 9 Oct 2023 09:34:11 +0200 Subject: [PATCH 1/2] Update beta from 1.3 to 1.2. (#379) --- partitioned-heat-conduction-complex/fenics/heat.py | 2 +- partitioned-heat-conduction-direct/nutils/heat.py | 2 +- partitioned-heat-conduction/nutils/heat.py | 2 +- partitioned-heat-conduction/openfoam-dirichlet/0.orig/T | 2 +- .../openfoam-dirichlet/setInitialField.sh | 2 +- partitioned-heat-conduction/openfoam-neumann/0.orig/T | 2 +- partitioned-heat-conduction/openfoam-neumann/setInitialField.sh | 2 +- partitioned-heat-conduction/openfoam-solver/heatTransfer.C | 2 +- 8 files changed, 8 insertions(+), 8 deletions(-) diff --git a/partitioned-heat-conduction-complex/fenics/heat.py b/partitioned-heat-conduction-complex/fenics/heat.py index 9ba1f519c..c654aff24 100644 --- a/partitioned-heat-conduction-complex/fenics/heat.py +++ b/partitioned-heat-conduction-complex/fenics/heat.py @@ -75,7 +75,7 @@ def determine_gradient(V_g, u, flux): # Error is bounded by coupling accuracy. In theory we can obtain the analytical solution. error_tol = 10 ** -6 alpha = 3 # parameter alpha -beta = 1.3 # parameter beta +beta = 1.2 # parameter beta gamma = args.gamma # parameter gamma, dependence of heat flux on time # Create mesh and separate mesh components for grid, boundary and coupling interface diff --git a/partitioned-heat-conduction-direct/nutils/heat.py b/partitioned-heat-conduction-direct/nutils/heat.py index e3ab91d98..96e31ac0f 100644 --- a/partitioned-heat-conduction-direct/nutils/heat.py +++ b/partitioned-heat-conduction-direct/nutils/heat.py @@ -7,7 +7,7 @@ import precice -def main(side='Dirichlet', n=10, degree=1, timestep=.1, alpha=3., beta=1.3): +def main(side='Dirichlet', n=10, degree=1, timestep=.1, alpha=3., beta=1.2): if side == 'Dirichlet': x_grid = np.linspace(0, 1, n) diff --git a/partitioned-heat-conduction/nutils/heat.py b/partitioned-heat-conduction/nutils/heat.py index 27046418c..e821fc2a8 100644 --- a/partitioned-heat-conduction/nutils/heat.py +++ b/partitioned-heat-conduction/nutils/heat.py @@ -7,7 +7,7 @@ import precice -def main(side='Dirichlet', n=10, degree=1, timestep=.1, alpha=3., beta=1.3): +def main(side='Dirichlet', n=10, degree=1, timestep=.1, alpha=3., beta=1.2): if side == 'Dirichlet': x_grid = np.linspace(0, 1, n) diff --git a/partitioned-heat-conduction/openfoam-dirichlet/0.orig/T b/partitioned-heat-conduction/openfoam-dirichlet/0.orig/T index fed3ddbc4..f90cb60d5 100644 --- a/partitioned-heat-conduction/openfoam-dirichlet/0.orig/T +++ b/partitioned-heat-conduction/openfoam-dirichlet/0.orig/T @@ -22,7 +22,7 @@ boundaryField DirichletBoundary { type groovyBC; - variables "val=1+pow(pos().x,2)+(3*pow(pos().y,2))+1.3*time();"; + variables "val=1+pow(pos().x,2)+(3*pow(pos().y,2))+1.2*time();"; valueExpression "val"; value uniform 0; evaluateDuringConstruction 1; diff --git a/partitioned-heat-conduction/openfoam-dirichlet/setInitialField.sh b/partitioned-heat-conduction/openfoam-dirichlet/setInitialField.sh index bf3dfd29c..02d282160 100755 --- a/partitioned-heat-conduction/openfoam-dirichlet/setInitialField.sh +++ b/partitioned-heat-conduction/openfoam-dirichlet/setInitialField.sh @@ -5,4 +5,4 @@ set -e -u rm -rf ./0 cp -r ./0.orig 0 # Initialize the new field -funkySetFields -keepPatches -field T -expression '1+pow(pos().x,2)+(3*pow(pos().y,2))+1.3*time()' -time '0' +funkySetFields -keepPatches -field T -expression '1+pow(pos().x,2)+(3*pow(pos().y,2))+1.2*time()' -time '0' diff --git a/partitioned-heat-conduction/openfoam-neumann/0.orig/T b/partitioned-heat-conduction/openfoam-neumann/0.orig/T index 01f8fc1af..753212b67 100644 --- a/partitioned-heat-conduction/openfoam-neumann/0.orig/T +++ b/partitioned-heat-conduction/openfoam-neumann/0.orig/T @@ -22,7 +22,7 @@ boundaryField DirichletBoundary { type groovyBC; - variables "val=1+pow(pos().x,2)+(3*pow(pos().y,2))+1.3*time();"; + variables "val=1+pow(pos().x,2)+(3*pow(pos().y,2))+1.2*time();"; valueExpression "val"; value uniform 0; evaluateDuringConstruction 1; diff --git a/partitioned-heat-conduction/openfoam-neumann/setInitialField.sh b/partitioned-heat-conduction/openfoam-neumann/setInitialField.sh index bf3dfd29c..02d282160 100755 --- a/partitioned-heat-conduction/openfoam-neumann/setInitialField.sh +++ b/partitioned-heat-conduction/openfoam-neumann/setInitialField.sh @@ -5,4 +5,4 @@ set -e -u rm -rf ./0 cp -r ./0.orig 0 # Initialize the new field -funkySetFields -keepPatches -field T -expression '1+pow(pos().x,2)+(3*pow(pos().y,2))+1.3*time()' -time '0' +funkySetFields -keepPatches -field T -expression '1+pow(pos().x,2)+(3*pow(pos().y,2))+1.2*time()' -time '0' diff --git a/partitioned-heat-conduction/openfoam-solver/heatTransfer.C b/partitioned-heat-conduction/openfoam-solver/heatTransfer.C index 6194f6fc1..65269836f 100644 --- a/partitioned-heat-conduction/openfoam-solver/heatTransfer.C +++ b/partitioned-heat-conduction/openfoam-solver/heatTransfer.C @@ -62,7 +62,7 @@ int main(int argc, char *argv[]) Info<< "\nCalculating temperature distribution\n" << endl; const double alpha = 3; - const double beta = 1.3; + const double beta = 1.2; const double rhs = beta - 2 - 2 * alpha; volScalarField f From 1c618c731725e944a9b70f59cfd324b1f3359c0a Mon Sep 17 00:00:00 2001 From: Benjamin Rodenberg Date: Thu, 25 Jan 2024 16:27:12 +0100 Subject: [PATCH 2/2] Fix beta. Amendment to #379. --- partitioned-heat-conduction/fenics/heat.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/partitioned-heat-conduction/fenics/heat.py b/partitioned-heat-conduction/fenics/heat.py index e7b7f6529..74c891f94 100644 --- a/partitioned-heat-conduction/fenics/heat.py +++ b/partitioned-heat-conduction/fenics/heat.py @@ -67,7 +67,7 @@ def determine_gradient(V_g, u, flux): error_tol = args.error_tol alpha = 3 # parameter alpha -beta = 1.3 # parameter beta +beta = 1.2 # parameter beta if args.dirichlet and not args.neumann: problem = ProblemType.DIRICHLET