Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release v202211.1 #558

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Release v202211.1 #558

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8109756
Update beta from 1.3 to 1.2. (#379)
BenjaminRodenberg Oct 9, 2023
1c618c7
Fix beta. Amendment to #379.
BenjaminRodenberg Jan 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion partitioned-heat-conduction-complex/fenics/heat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ def determine_gradient(V_g, u, flux):
# Error is bounded by coupling accuracy. In theory we can obtain the analytical solution.
error_tol = 10 ** -6
alpha = 3 # parameter alpha
beta = 1.3 # parameter beta
beta = 1.2 # parameter beta
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to change a model parameter in a bugfix release? I know that this was changed in the v202404, but wouldn't this confuse users if v202211.0 and v202211.1 have different values?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parameter was not consistent with literature. So I would consider it as a bug that we can also fix in a bugfix release. But let's continue this discussion in #378.

gamma = args.gamma # parameter gamma, dependence of heat flux on time

# Create mesh and separate mesh components for grid, boundary and coupling interface
Expand Down
2 changes: 1 addition & 1 deletion partitioned-heat-conduction-direct/nutils/heat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
import precice


def main(side='Dirichlet', n=10, degree=1, timestep=.1, alpha=3., beta=1.3):
def main(side='Dirichlet', n=10, degree=1, timestep=.1, alpha=3., beta=1.2):

if side == 'Dirichlet':
x_grid = np.linspace(0, 1, n)
Expand Down
2 changes: 1 addition & 1 deletion partitioned-heat-conduction/fenics/heat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ def determine_gradient(V_g, u, flux):
error_tol = args.error_tol

alpha = 3 # parameter alpha
beta = 1.3 # parameter beta
beta = 1.2 # parameter beta

if args.dirichlet and not args.neumann:
problem = ProblemType.DIRICHLET
Expand Down
2 changes: 1 addition & 1 deletion partitioned-heat-conduction/nutils/heat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
import precice


def main(side='Dirichlet', n=10, degree=1, timestep=.1, alpha=3., beta=1.3):
def main(side='Dirichlet', n=10, degree=1, timestep=.1, alpha=3., beta=1.2):

if side == 'Dirichlet':
x_grid = np.linspace(0, 1, n)
Expand Down
2 changes: 1 addition & 1 deletion partitioned-heat-conduction/openfoam-dirichlet/0.orig/T
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ boundaryField
DirichletBoundary
{
type groovyBC;
variables "val=1+pow(pos().x,2)+(3*pow(pos().y,2))+1.3*time();";
variables "val=1+pow(pos().x,2)+(3*pow(pos().y,2))+1.2*time();";
valueExpression "val";
value uniform 0;
evaluateDuringConstruction 1;
Expand Down
2 changes: 1 addition & 1 deletion partitioned-heat-conduction/openfoam-dirichlet/setInitialField.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@ set -e -u
rm -rf ./0
cp -r ./0.orig 0
# Initialize the new field
funkySetFields -keepPatches -field T -expression '1+pow(pos().x,2)+(3*pow(pos().y,2))+1.3*time()' -time '0'
funkySetFields -keepPatches -field T -expression '1+pow(pos().x,2)+(3*pow(pos().y,2))+1.2*time()' -time '0'
2 changes: 1 addition & 1 deletion partitioned-heat-conduction/openfoam-neumann/0.orig/T
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ boundaryField
DirichletBoundary
{
type groovyBC;
variables "val=1+pow(pos().x,2)+(3*pow(pos().y,2))+1.3*time();";
variables "val=1+pow(pos().x,2)+(3*pow(pos().y,2))+1.2*time();";
valueExpression "val";
value uniform 0;
evaluateDuringConstruction 1;
Expand Down
2 changes: 1 addition & 1 deletion partitioned-heat-conduction/openfoam-neumann/setInitialField.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@ set -e -u
rm -rf ./0
cp -r ./0.orig 0
# Initialize the new field
funkySetFields -keepPatches -field T -expression '1+pow(pos().x,2)+(3*pow(pos().y,2))+1.3*time()' -time '0'
funkySetFields -keepPatches -field T -expression '1+pow(pos().x,2)+(3*pow(pos().y,2))+1.2*time()' -time '0'
2 changes: 1 addition & 1 deletion partitioned-heat-conduction/openfoam-solver/heatTransfer.C
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ int main(int argc, char *argv[])
Info<< "\nCalculating temperature distribution\n" << endl;

const double alpha = 3;
const double beta = 1.3;
const double beta = 1.2;
const double rhs = beta - 2 - 2 * alpha;

volScalarField f
Expand Down