Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: global update should add new executables #2298

Merged
merged 14 commits into from
Oct 18, 2024
Merged

feat: global update should add new executables #2298

merged 14 commits into from
Oct 18, 2024

Conversation

nichmor
Copy link
Contributor

@nichmor nichmor commented Oct 16, 2024 •
edited
Loading

This PR aims to change how pixi global update picks up and exposes new binaries.

  • If the user initially chooses to auto-exposed everything, after the update we will remove binaries that are not anymore present and will expose the new ones. A good example of this could be python upgrade - we will remove python3.8 and will add python.39
  • If the user initially exposed only a small subset of binaries, we will not auto-expose the new ones.

image

  • adding python 3.8 and then modifying it manually to >=3.8, <3.10 as spec will result in this output

@nichmor nichmor marked this pull request as draft October 16, 2024 15:03
@nichmor nichmor marked this pull request as ready for review October 17, 2024 09:19
Hofer-Julian
Hofer-Julian reviewed Oct 17, 2024
View reviewed changes
Copy link
Contributor

@Hofer-Julian Hofer-Julian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a review of the code, since I didn't test it locally yet. I added a few comments.

In the description of this PR, you outlined quite nicely how the new behavior works. Could you please also do that in the docstring of the command?

.pre-commit-config.yaml Outdated Show resolved Hide resolved
src/cli/global/list.rs Outdated Show resolved Hide resolved
src/global/common.rs Outdated Show resolved Hide resolved
src/global/common.rs Outdated Show resolved Hide resolved
src/global/common.rs Outdated
let exposed_binaries_names = exposed_mapping_binaries
.iter()
.map(|mapping| mapping.executable_name())
.collect_vec();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^ here I think it will not work because I need to check if a name is in this exposed list. Changed it to hashset though ( instead of vec )

src/global/project/manifest.rs Outdated Show resolved Hide resolved
src/global/project/mod.rs Outdated Show resolved Hide resolved
src/global/project/mod.rs Show resolved Hide resolved
tests/integration/test_global.py Outdated Show resolved Hide resolved
tests/integration/test_global.py Outdated Show resolved Hide resolved
@Hofer-Julian
Copy link
Contributor

I've now tested it locally and it works fine.

The tests on Windows are failing though.

nichmor and others added 10 commits October 17, 2024 14:38
@nichmor
misc: rever pre-commit config
f9a0f3b
@nichmor @Hofer-Julian
Update src/cli/global/list.rs
041b665 
Co-authored-by: Hofer-Julian <30049909+Hofer-Julian@users.noreply.github.com>
@nichmor @Hofer-Julian
Update src/global/project/mod.rs
89239ec 
Co-authored-by: Hofer-Julian <30049909+Hofer-Julian@users.noreply.github.com>
@nichmor @Hofer-Julian
Update tests/integration/test_global.py
8143caf 
Co-authored-by: Hofer-Julian <30049909+Hofer-Julian@users.noreply.github.com>
@nichmor @Hofer-Julian
Update tests/integration/test_global.py
8eb8b1c 
Co-authored-by: Hofer-Julian <30049909+Hofer-Julian@users.noreply.github.com>
@nichmor
misc: apply refactor changes
6234700
@nichmor
Merge branch 'feat/global-update-should-add-new-executables' of https…
45a2bbf 
…://github.com/nichmor/pixi into feat/global-update-should-add-new-executables
@nichmor
misc: apply refactor changes
c45995d
@nichmor
Merge branch 'main' into feat/global-update-should-add-new-executables
b71402a
@nichmor
Merge branch 'main' into feat/global-update-should-add-new-executables
d738bf7
@Hofer-Julian Hofer-Julian merged commit d412ea0 into prefix-dev:main Oct 18, 2024
40 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Oct 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hofer-Julian Hofer-Julian Hofer-Julian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nichmor @Hofer-Julian