Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use --host-platform instead of --target-platform #1075

Closed
beckermr opened this issue Oct 1, 2024 · 3 comments
Closed

use --host-platform instead of --target-platform #1075

beckermr opened this issue Oct 1, 2024 · 3 comments

Comments

@beckermr
Copy link

beckermr commented Oct 1, 2024

@isuruf would like to see us use --host-platform instead of --target-platform when calling rattler-build.

We should add an alias for now.

xref: conda-forge/conda-smithy#2070 (comment)

@wolfv
Copy link
Member

wolfv commented Oct 2, 2024

This goes beyond just the CLI argument: target_platform is used throughout the build process and is even part of the hash. It's part of every variant (e.g. you can always do if: target_platform == build_platform etc.

I think renaming it is relatively breaking at this point.

We could still alias it, but the question would be if we want to phase out target_platform over the long run.

Personally it doesn't bother me so much. I am a little sad that it only comes up now (after rattler-build has been around for quite some time) - would have been cool to discuss this earlier (or as part of a CEP).

@isuruf
Copy link

isuruf commented Oct 2, 2024

as part of a CEP

We did discuss the in the case of requirements where we went with build and host, but not exactly _platform.

I'm not saying we remove target_platform. In almost all cases host_platform == target_platform and differs only in the case of compilers.
We should use host_platform to mean the platform of host and build_platform to mean the platform of build which makes it clear.
target_platform is the platform where the code generated by the compiler can run on instead of the platform where the compiler is run.

@wolfv
Copy link
Member

wolfv commented Oct 7, 2024

Fixed in #1087

@wolfv wolfv closed this as completed Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants