docs: update numpy recipe in Python examples page #1015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A couple of reasons for these changes:
- the current example for numpy 1.26.4 uses a couple of submodules that no longer exist
- the NumPy C API export changed a lot, so advertise that (and no longer use `pin_subpackage`)
- there's a second entrypoint in numpy 2.0 (`numpy-config`) that's also nice to add
- the build/host split may be confusing to the reader, since it contradicts what is
explained in the cross compilinng docs ("tools that run on the build machine
go under `build:`); the current setup only makes sense when using `crossenv`, like
conda-forge does.
Hofer-Julian
approved these changes
Aug 12, 2024
There was a problem hiding this comment.
Thanks a lot @rgommers!
I tested the recipe locally and it works as expected :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of reasons for these changes:
pin_subpackage)numpy-config) that's also nice to addbuild:"); the current setup only makes sense when usingcrossenv, like conda-forge does.