refactor: make build string optional in recipe #1020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baszalmstra
changed the title
nichmor
approved these changes
Aug 16, 2024
baszalmstra
force-pushed
the
refactor/no_default_build_string
branch
from
d3477f8
to
e04d897
Compare
baszalmstra
force-pushed
the
refactor/no_default_build_string
branch
from
920e032
to
1b3a01f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
buildstring in the recipe was an optional value in name only. The code always assumed it has a value, which it always got during parsing. This PR changes this behavior so that the recipe datastructure actually contains an optional build but the code usesOutput::build_string()to get the actual builds string which is either based on the hash or on the user-defined value.This also allowed me to remove a bunch of unwraps.
I also reformatted some files with the nightly formatter.