Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve env var handling #1088

Merged
merged 5 commits into from
Oct 7, 2024
Merged

fix: improve env var handling #1088

merged 5 commits into from
Oct 7, 2024

Conversation

wolfv
Copy link
Member

@wolfv wolfv commented Oct 7, 2024

This fixes a number of issues with regards to how env vars are put together.

The next step will be to also analyze the variant configuration and extract environment variables from the variant configuration as necessary.

TODO:

  • Add in variant config to environment (except for special keys "PYTHON", "R", ...
  • Detect "used" keys from variant and use them to override the env vars

@wolfv wolfv merged commit 0e397d0 into prefix-dev:main Oct 7, 2024
15 checks passed
@wolfv wolfv deleted the env-vars-ii branch October 7, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant