Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: copy permissions when reflinking files #1111

Merged
merged 2 commits into from
Oct 11, 2024
Merged

fix: copy permissions when reflinking files #1111

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a6f05bf
fix copying the permissions when running copydir
wolfv Oct 11, 2024
7765018
..
wolfv Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/source/copy_dir.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,7 +380,18 @@ where
}

// Reflink or copy the file
reflink_copy::reflink_or_copy(from, to)?;
match reflink_copy::reflink_or_copy(from, &to)? {
None => {
// File has been reflinked, on Linux we need to copy the permissions
#[cfg(target_os = "linux")]
{
let metadata = fs_err::metadata(from)?;
let permissions = metadata.permissions();
fs_err::set_permissions(to, permissions)?;
}
}
Some(_) => {}
}

Ok(())
}
Expand Down
Loading