Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: keep installed packages in environments #1119

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

wolfv
Copy link
Member

@wolfv wolfv commented Oct 14, 2024

No description provided.

@wolfv
Copy link
Member Author

wolfv commented Oct 14, 2024

The way this is done right now is a bit ad-hoc.

For the host-env cleaning we are not making sure that any files were touched. This might be something to fix by e.g. looking at all the hashes in the host env and comparing with what's written in the PrefixRecord.

For the work dir, we just rm -rf the whole thing. That removes any CMakeCache file or other intermediary output from the previous run.

We could instead:

  • render out the sources into a JSON and store that in the workdir, to check if there are any different patches and only then recreate the whole work dir from scratch?
  • add a --keep-work-dir flag to not recreate it, and keep the current recreate-from-scratch logic? This might actually be useful if people do little tweaks to the contents directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant