Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: error collect as vec #407

Merged
merged 2 commits into from
Dec 12, 2023
Merged

Conversation

swarnimarun
Copy link
Contributor

@swarnimarun swarnimarun commented Dec 7, 2023

We now show most of the errors other than yaml parsing itself at once.
image

@swarnimarun swarnimarun marked this pull request as ready for review December 8, 2023 10:27
@swarnimarun
Copy link
Contributor Author

Currently each unit of MappingNode, needs to implement error collection, until then we will stop at the first error in each MappingNode.

@swarnimarun
Copy link
Contributor Author

I think I will create issues for it, we can slowly implement it for each mapping node.

@wolfv wolfv merged commit 9c84e3d into prefix-dev:main Dec 12, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants