Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add variant schema #10

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

swarnimarun
Copy link
Contributor

TODO: need to add inline documentation.

@pavelzw
Copy link
Contributor

pavelzw commented Jan 17, 2024

Closes prefix-dev/rattler-build#295

All compilers and compiler versions are still missing. Also we need macos deployment target. Is that already incorporated into rattler-build?

@wolfv
Copy link
Member

wolfv commented Jan 18, 2024

@pavelzw I don't think compilers are in any way "mandatory" - they are just another variant config value. How do you envision them to be added?

@pavelzw
Copy link
Contributor

pavelzw commented Jan 18, 2024

Maybe something like this?

compilers:
  cpp:
    name/package/???: clang
    version: '12.0'
  <any-key>:
    ...

Otherwise just an entry for the most common compilers c, cpp, rust, go, go-nocgo, ... to make auto completion easier

@wolfv
Copy link
Member

wolfv commented Jan 18, 2024

@pavelzw I like it – but this might need a CEP etc.

I also think we could add another nesting level so that we have:


zip_keys:
 ...
pins:
 ...
compilers:
 ...
pin_run_as_build:
 ...

But again, we haven't actually done any thinking on it yet.

Currently the compiler are as they used to be

compiler_cxx: ...
compiler_c: ...

Similarly for that `variant_schema.json` add,

```yaml
# yaml-language-server: $schema=https://raw.githubusercontent.com/prefix-dev/recipe-format/main/variant_schema.json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how you guys feel about this, how about changing this to some link at prefix.dev that is a 300 to this URL? This would allow you to use better versioning and not be bound by this specific location in the repo if you ever decide on moving/renaming these files.

add some more docs & support if conditional in zip keys
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants