Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't exit the shell on syntax error #33

Closed
Tracked by #35
certik opened this issue Sep 6, 2024 · 4 comments
Closed
Tracked by #35

Don't exit the shell on syntax error #33

certik opened this issue Sep 6, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@certik
Copy link
Collaborator

certik commented Sep 6, 2024

C:\Program Files\Git$ cd ~
Error: Failed to execute

Caused by:
     --> 1:4
      |
    1 | cd ~
      |    ^---
      |
      = expected EOI, AND_IF, OR_IF, Stdout, StdoutStderr, cmd_suffix, or separator_op
error: process didn't exit successfully: `target\debug\shell.exe` (exit code: 1)

This exits the shell. Instead show the next prompt.

@certik certik added bug Something isn't working high priority labels Sep 6, 2024
@certik
Copy link
Collaborator Author

certik commented Sep 6, 2024

This one is high priority, as for daily use, we do not want to exit the shell if I mistype something or try to use a feature that is not implemented yet.

@prsabahrami
Copy link
Collaborator

I am working on adding miette support for pest.
That way this can be easily taken care of.

@prsabahrami
Copy link
Collaborator

This has been fixed in #38
Support for miette should be added later. Switching from bug to enhancement.

@prsabahrami prsabahrami added enhancement New feature or request and removed bug Something isn't working high priority labels Sep 6, 2024
@certik
Copy link
Collaborator Author

certik commented Sep 8, 2024

This issue is fixed. I opened a new one (#77) for miette.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants