-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement --no-exit
#118
Conversation
@certik would be happy to hear your thoughts. For now, this can work as a custom "RC" file thing (e.g. you could point your shell to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that's fine. Isn't there a more descriptive command line option? I first thought --no-exit
will not allow you to exit, which might not be what was intended. :)
@certik what do you think about |
That's better. Maybe also |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #118 +/- ##
==========================================
- Coverage 62.04% 61.93% -0.11%
==========================================
Files 30 30
Lines 2959 2961 +2
==========================================
- Hits 1836 1834 -2
- Misses 1123 1127 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Used --interact
instead of --no-exit
.
Works for me! |
This is what powershell implements and it's quite useful in my opinion.
It allows us to execute a script (after RC files) and then drop into an interactive prompt. For something like
pixi shell
this is very useful.