Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added windows and macos CI #160

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Added windows and macos CI #160

merged 1 commit into from
Sep 26, 2024

Conversation

prsabahrami
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.08%. Comparing base (3a20581) to head (8c6e6d4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #160      +/-   ##
==========================================
- Coverage   58.12%   58.08%   -0.04%     
==========================================
  Files          29       29              
  Lines        2813     2813              
==========================================
- Hits         1635     1634       -1     
- Misses       1178     1179       +1     
Flag Coverage Δ
58.08% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@prsabahrami
Copy link
Collaborator Author

@wolfv I think you need to update the branch protection rules here for this.

@prsabahrami prsabahrami mentioned this pull request Sep 26, 2024
@certik
Copy link
Collaborator

certik commented Sep 26, 2024

@wolfv let's get this PR in, we need to have solid testing on all platforms.

Copy link
Contributor

@Hofer-Julian Hofer-Julian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've adapted the rules.
Thanks @prsabahrami!

@Hofer-Julian Hofer-Julian merged commit 18c2d80 into main Sep 26, 2024
8 of 9 checks passed
@Hofer-Julian Hofer-Julian deleted the windows-ci branch September 26, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants