Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix variable in quoted string #171

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Conversation

prsabahrami
Copy link
Collaborator

Closes #130

@prsabahrami prsabahrami linked an issue Sep 29, 2024 that may be closed by this pull request
Copy link

codecov bot commented Sep 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.08%. Comparing base (89c4910) to head (2e373d1).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #171      +/-   ##
==========================================
+ Coverage   62.04%   62.08%   +0.03%     
==========================================
  Files          30       30              
  Lines        2959     2959              
==========================================
+ Hits         1836     1837       +1     
+ Misses       1123     1122       -1     
Flag Coverage Δ
62.08% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@certik
Copy link
Collaborator

certik commented Sep 30, 2024

Thanks! Let's add a test as well.

@wolfv wolfv merged commit 90d3346 into main Sep 30, 2024
9 checks passed
@wolfv wolfv deleted the 130-allow-environment-variables-inside branch September 30, 2024 06:05
@wolfv
Copy link
Member

wolfv commented Sep 30, 2024

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow environment variables inside "".
3 participants