add multiline test script #65
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would be good to tackle #50, so that this is actually checked in CI |
prsabahrami
reviewed
Sep 10, 2024
| )* } | ||
|
|
||
| UNQUOTED_ESCAPE_CHAR = ${ ("\\" ~ "$" | "$" ~ !"(" ~ !VARIABLE) | "\\" ~ (" " | "`" | "\"" | "(" | ")")* } | ||
| QUOTED_ESCAPE_CHAR = ${ "\\" ~ "$" | "$" ~ !"(" ~ !VARIABLE | "\\" ~ ("`" | "\"" | "(" | ")" | "'")* } | ||
| QUOTED_ESCAPE_CHAR = @{ "\\" ~ ("$" | "`" | "\"" | "(" | ")" | "'" | "\n" | "\r\n") } |
There was a problem hiding this comment.
The reason behind adding "$" ~ !"(" ~ !VARIABLE to QUOTED_ESCAPE_CHAR was since bash parses $ as is when not followed by a variable, subcommand or brace_group - we need to add support for brace_groups later as well.
For example:
echo "$" prints the same value as echo \$"
| @@ -203,8 +202,8 @@ filename = _{ FILE_NAME_PENDING_WORD } | |||
| io_here = !{ (DLESS | DLESSDASH) ~ here_end } | |||
| here_end = @{ ("\"" ~ UNQUOTED_PENDING_WORD ~ "\"") | UNQUOTED_PENDING_WORD } | |||
|
|
|||
| newline_list = _{ NEWLINE+ } | |||
| linebreak = _{ NEWLINE* } | |||
| newline_list = _{ (NEWLINE | ESCAPED_NEWLINE)+ } | |||
There was a problem hiding this comment.
Pest automatically parses WHITESPACE between every ~ or repetition of + or *. Since ESCAPED_NEWLINE is being checked in WHITESPACE, I don't think it is necessary to check ESCAPED_NEWLINE here once more.
Same goes for the line below.
|
I think we can close this because of we now support building tests from scripts in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a test script that currently also does not parse completely right.
When we have open quotes, we should continue parsing things (and add the
\ninto the string.When we have a
\escape, then the\nshould not be part of the string.Luckily it's easy to test this against
bashorzshbehavior :)