SVG support for graph #108
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't understand what the change is for (you haven't provided description in the PR). |
|
I'm sorry for that. "description" already fixed. |
|
Still not getting it, sorry. What does it change in UI or how it's affecting any existing logic? |
|
Now you can set .svg format here |
|
Then a line above https://github.com/preinheimer/xhprof/blob/master/xhprof_html/callgraph.php#L59 should be updated as well to include SVG. Any way to change format of call graph to SVG from config (see https://github.com/preinheimer/xhprof/blob/master/xhprof_lib/config.sample.php)? What benefits do you get from seeing call graph in svg vs png? I bet you can't really zoom-in or something like that or can you? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That branch needed to supporting graph images in .svg format