Skip to content
This repository has been archived by the owner on Dec 6, 2023. It is now read-only.

cht-petals: minor edits on paths and default parameters #125

Merged
merged 4 commits into from
Oct 30, 2023
Merged

cht-petals: minor edits on paths and default parameters #125

merged 4 commits into from
Oct 30, 2023

Conversation

biswaroop1547
Copy link
Collaborator

@biswaroop1547 biswaroop1547 commented Oct 26, 2023 •
edited
Loading

This PR takes care of:

  • minor fixes on cli params
  • stable beluga currently concatenates user prompt too in generated responses, make sure it only shows newly generated tokens.
  • adding configurable prompt template for stable beluga 2

@biswaroop1547 biswaroop1547 temporarily deployed to internal October 26, 2023 06:46 — with GitHub Actions Inactive
@biswaroop1547 biswaroop1547 temporarily deployed to internal October 26, 2023 06:50 — with GitHub Actions Inactive
@biswaroop1547 biswaroop1547 temporarily deployed to internal October 26, 2023 07:08 — with GitHub Actions Inactive
@biswaroop1547 biswaroop1547 temporarily deployed to internal October 26, 2023 07:13 — with GitHub Actions Inactive
@biswaroop1547 biswaroop1547 temporarily deployed to internal October 26, 2023 07:18 — with GitHub Actions Inactive
@biswaroop1547 biswaroop1547 temporarily deployed to internal October 26, 2023 07:19 — with GitHub Actions Inactive
casperdcl
casperdcl reviewed Oct 26, 2023
View reviewed changes
Copy link
Contributor

@casperdcl casperdcl left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the criteria for deciding between exposing a --cli-option vs ENV_VAR vs both?

@biswaroop1547
Copy link
Collaborator Author

what's the criteria for deciding between exposing a --cli-option vs ENV_VAR vs both?

I am thinking as per current structure: --cli-option is for usage in non-docker services vs ENV_VAR is for (containerised services (docker), though yeah docker could support multiple service builds with different --cli-option with tweaks on build.sh file too, open for discussion here.

@biswaroop1547 biswaroop1547 temporarily deployed to internal October 27, 2023 21:08 — with GitHub Actions Inactive
@biswaroop1547 biswaroop1547 marked this pull request as ready for review October 27, 2023 21:08
@biswaroop1547 biswaroop1547 mentioned this pull request Oct 27, 2023
Merged
8 tasks
@biswaroop1547 biswaroop1547 temporarily deployed to internal October 27, 2023 21:12 — with GitHub Actions Inactive
@casperdcl casperdcl added bug Something isn't working enhancement New feature or request labels Oct 30, 2023
@casperdcl casperdcl merged commit 2f5b2c5 into premAI-io:main Oct 30, 2023
5 of 6 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@casperdcl casperdcl casperdcl approved these changes

Assignees

@biswaroop1547 biswaroop1547

Labels
bug Something isn't working enhancement New feature or request
Projects
No open projects
Prem ML
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@biswaroop1547 @casperdcl