This repository has been archived by the owner on Dec 6, 2023. It is now read-only.
fix: redis script bug unbound variable #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
biswaroop1547
temporarily deployed
to
internal
GitHub Actions
Inactive
biswaroop1547
temporarily deployed
to
internal
GitHub Actions
Inactive
casperdcl
reviewed
Nov 3, 2023
| @@ -41,7 +41,6 @@ MODULEDIR="$tmpdir/lib" | |||
| --protected-mode no \ | |||
| --daemonize no \ | |||
| --loadmodule "${MODULEDIR}/redisearch.so" ${REDISEARCH_ARGS} \ | |||
| --loadmodule "${MODULEDIR}/redisgears.so" v8-plugin-path "${MODULEDIR}/libredisgears_v8_plugin.so" ${REDISGEARS_ARGS} \ | |||
| "$@") & | |||
There was a problem hiding this comment.
are you sure you can't do this instead?
Suggested change
| "$@") & | |
| --loadmodule "${MODULEDIR}/redisgears.so" v8-plugin-path "${MODULEDIR}/libredisgears_v8_plugin.so" \ | |
| "$@") & |
actually also is it still safe to put "$@" here? how does --loadmodule know which args are for the module and which are for redis-stack?
Are they all magically handled https://stackoverflow.com/q/55078246?
There was a problem hiding this comment.
so we don't need redisgears for vector db only redisearch is needed, and --loadmodule seems to take only the required arguments (from whatever I've tested locally) and all other arguments are passed down to redis-server hence setup-redis.sh --port 8001 works
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.