-
Notifications
You must be signed in to change notification settings - Fork 8
fix diffusers undefined REFINER_ID
#76
fix diffusers undefined REFINER_ID
#76
Conversation
dfs-diffusers/docker/gpu/Dockerfile
Outdated
@@ -11,7 +11,7 @@ RUN pip3 install --no-cache-dir -r requirements.txt | |||
|
|||
COPY download.py . | |||
|
|||
RUN python3 download.py --model $MODEL_ID --refiner $REFINER_ID | |||
RUN python3 download.py --model $MODEL_ID |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is the only change required, the rest can be reverted? i.e. pass empty string if not defined :)
RUN python3 download.py --model $MODEL_ID | |
RUN python3 download.py --model $MODEL_ID --refiner "$REFINER_ID" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@casperdcl then for this image build REFINER_ID won't be used correctly by download.py to download refiner only when given. Whereas it'll work for all the other image builds.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh wait I totally missed that you've put REFINER_ID inside quotes, my bad! damn this totally works then
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just pushed a commit (might make it clearer what I mean) - feel free to revert it if it doesn't make sense or doesn't work though. Basically:
- no
--build-arg
Dockerfile
executesdownload.py --refiner ""
argparse
parses intoargs.refiner = ""
(Falsey)
- using
--build-arg="REFINER_ID=..."
Dockerfile
executesdownload.py --refiner "..."
argparse
parses intoargs.refiner = "..."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the explanation! this makes sense, just tried locally and seems to be working nicely.
This reverts commit 9d4a145.
REFINER_ID
fixes #71